Try to match primary_role when roles are filtered #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an effort to match the primary_role from a list of specific roles.
eg: given a config like
and if we filter by site2:
Things will run on the first role + first host in the specific roles array, which is a bit unexpected given the primary_role we requested.
With this change it'll make an effort to match the primary_role:
Much nicer.
This also fixes a role filtered deploy issue we're seeing:
or
where kamal attempts to use the primary_role env on whatever role happens to come first.